Feat/generator render widgets #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klakurka
approved these changes
Nov 18, 2024
chedieck
approved these changes
Nov 19, 2024
|
One thing to notice: this branch has commits from #435, but not all of them (is out-of-date) When including changes from another branch in the PR branch, try to use the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #426
Description
Created a new field in the
generator.htmlto select whether it will render apaybuttonor apaybutton-widget.This change will help testing, before generator only rendered buttons now it can be used to widgets too.
Test plan
Run
yarn devaccesshttp://localhost:10001/paybutton-generator.htmltest generating widgets/buttons.